A few things I've found for the Beta test...
1) I added title='' and alt='' tags to some of the images and links using %PRODUCT_NAME% as the value. Some of my product names have quotes in them, so the title and alt tags were ended before they should have been (title='this product's name has a quote'). I tried adding htmlentities() in several of the plugin files but I don't think I resolved the problem. For any data you provide as replacement tokens, it might be a good idea to handle quotes.
2) Similar issue as 1, but with image urls. Some of my image urls have quotes in them (not sure why). Would htmlentities help resolve these issues as well?
3) I originally use /category as the Category Base HREF, but then I found that /category is used by wordpress for category pages. So there will be a conflict if you use /category for the base href and you also want to use normal wordpress categories.
4) I would really like to have widgets for category, merchant and brand lists (links). These lists could be placed into the sidebars as navigation. Or could you provide a widget that allows shortcodes? And include shortcodes for these lists? (not sure if that really makes sense)
Anyway, still enjoying the plugin and trying to get it to do what I want.
Thanks,
Gregor
Thanks again for the feedback Gregor, I'll be posting an update tomorrow taking quite a bit of feedback from the forum and by email into account. Merchant / Category / Brand index widgets would be straight forward; they do have to be handled with care however based on the query time required to generate them dynamically. Understandalone Price Tapestry I have only recommended it for very niche sites with only a small number of categories / brands etc. - however since my aim for this plugin is to power niche sites (the whole point of using WordPress) I'll definitely get them included...
Cheers,
David.
That's great. Thank you David.
I'm also struggling with my H1 tags on the search pages. The H1 for search pages is always the shopping page name, but for pages like category and merchant product lists I would like to have the category name or merchant name as the h1 (plus a word or two before / after). Do you have any idea how I would do this?
Cheers
Hi Gregor,
I've just posted an update containing the HTML entity fix. The reason it may not have worked in your experiment is because by default quotes are not encoded, however by adding the optional flag ENT_QUOTES they are encoded and will not break the markup. If you want to modify your version rather than re-install as I know you have made several changes to your HTML design where you may have used, for example;
htmlentities($product->name)...instead use:
htmlentities($product->name,ENT_QUOTES)Regarding the `Shopping` page title override for merchant / category / brand pages, you might want to try the following. In pto.php look for the following code around line 421:
$content = $title." | ".$content;...and REPLACE with:
if ($pto_q)
{
$p = explode(":",$pto_q);
if (in_array($p[0],array("merchant","category","brand")))
{
$title = $p[1];
$title_override = TRUE;
}
}
$content = $title." | ".$content;And if you want before / after text, in place of:
$title = $p[1];...use:
$title = "Before ".$p[1]." After";Cheers!
David.
David you are correct. I missed the ENT_QUOTES addition the first time, but went back and fixed it. Working now. The H1 code also works perfectly. Thanks you!
Gregor
I was able to resolve the quote issues with htmlentities, but my solution is probably incomplete. Might be nice to have a comprehensive solution.
Thanks,
Gregor